Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the setup and verification steps in the GitHub Actions workflows, mainly by removing the dedicated
set-package-nameaction and integrating its logic directly into relevant workflow steps. It also enhances theverify-structureaction to support custom directory and file checks, and updates documentation accordingly.Workflow and Action Refactoring:
set-package-namecomposite action and replaced it with an inline Bash step in thesetup-uv-pythonaction, simplifying environment variable setup forPACKAGE_NAME. (.github/actions/setup/set-package-name/action.ymlremoved,[.github/actions/setup/setup-uv-python/action.ymlR16-R20](https://github.com/javidahmed64592/template-python/pull/30/files#diff-eb0c5f8c32887b82dbf98c3a7f932b53161cf242424a178864e21e0962a563faR16-R20))build.yml,ci.yml) to remove references to theset-package-nameaction, relying instead on the new inline step. ([[1]](https://github.com/javidahmed64592/template-python/pull/30/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L16-L19),[[2]](https://github.com/javidahmed64592/template-python/pull/30/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L30-L33),[[3]](https://github.com/javidahmed64592/template-python/pull/30/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL52-L55))Enhancements to Structure Verification:
expected-directoriesandexpected-filesinputs in theverify-structureaction, allowing workflows to check for additional directories and files withinsite-packages. ([.github/actions/build/verify-structure/action.ymlR4-R13](https://github.com/javidahmed64592/template-python/pull/30/files#diff-bd52ab90a0a08f216430880f6229c55c9cce1a60a5fd113c7bb08980a030748dR4-R13))verify-structureaction to dynamically build and verify lists of required directories and files based on provided inputs. ([.github/actions/build/verify-structure/action.ymlR49-R92](https://github.com/javidahmed64592/template-python/pull/30/files#diff-bd52ab90a0a08f216430880f6229c55c9cce1a60a5fd113c7bb08980a030748dR49-R92))Documentation Updates:
set-package-nameaction and updated usage examples to reflect the new approach. ([[1]](https://github.com/javidahmed64592/template-python/pull/30/files#diff-ed9b8f4a4f6633f84a0d372314788cf32c9dac97a3753a915b9a848ebc14c4cfL68-L82),[[2]](https://github.com/javidahmed64592/template-python/pull/30/files#diff-ed9b8f4a4f6633f84a0d372314788cf32c9dac97a3753a915b9a848ebc14c4cfL158),[[3]](https://github.com/javidahmed64592/template-python/pull/30/files#diff-ed9b8f4a4f6633f84a0d372314788cf32c9dac97a3753a915b9a848ebc14c4cfL219))verify-structureaction to describe its new capabilities and provide advanced usage examples with custom directory and file checks. ([docs/WORKFLOWS.mdL232-R235](https://github.com/javidahmed64592/template-python/pull/30/files#diff-ed9b8f4a4f6633f84a0d372314788cf32c9dac97a3753a915b9a848ebc14c4cfL232-R235))